Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #511. Use INT64 for SYSTEM_CLOCK #768

Merged
merged 4 commits into from
Mar 23, 2021

Conversation

mathomp4
Copy link
Member

@mathomp4 mathomp4 commented Mar 22, 2021

Description

Uses INT64 for system_clock() calls in MAPL. This should prevent negative throughputs.

I also changed all the other places I saw system_clock() that could be in libMAPL.a. Note there are some programs and tests that are still INT32 but I figure they don't quite need it.

Related Issue

Closes #511

Motivation and Context

Can prevent rare negative throughputs, and other timers.

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@mathomp4 mathomp4 added the 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. label Mar 22, 2021
@mathomp4 mathomp4 self-assigned this Mar 22, 2021
@mathomp4
Copy link
Member Author

Note: I need to actually build and run this, so keeping this as draft at the moment.

Thanks to @tclune for help with this. Was fun. Every timer was negative!
@mathomp4
Copy link
Member Author

Tested with a run of GEOS with GNU Debug. Runs and is zero-diff.

@mathomp4 mathomp4 marked this pull request as ready for review March 22, 2021 19:41
@mathomp4 mathomp4 requested a review from a team as a code owner March 22, 2021 19:41
@mathomp4 mathomp4 merged commit da7c697 into develop Mar 23, 2021
@mathomp4 mathomp4 deleted the feature/mathomp4/#511-system-clock-int64 branch March 23, 2021 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants