Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #562. Debug Level logger fix in ExtData #564

Merged
merged 1 commit into from
Oct 8, 2020
Merged

Fixes #562. Debug Level logger fix in ExtData #564

merged 1 commit into from
Oct 8, 2020

Conversation

mathomp4
Copy link
Member

@mathomp4 mathomp4 commented Oct 8, 2020

Description

Bug fix for a debug logger in MAPL_ExtDataGridComp

Related Issue

Fixes #562

Motivation and Context

Fixes a bug in logging

How Has This Been Tested?

The code ran with it and crashed without it.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@mathomp4 mathomp4 added 0 Diff Trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) bugfix labels Oct 8, 2020
@mathomp4 mathomp4 requested a review from a team as a code owner October 8, 2020 14:28
@mathomp4 mathomp4 self-assigned this Oct 8, 2020
@tclune tclune merged commit f0dea39 into main Oct 8, 2020
@tclune tclune deleted the hotfix/mathomp4/#562-debug-logger-fix branch October 8, 2020 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tclune tclune tclune approved these changes

Assignees

@mathomp4 mathomp4

Labels
0 Diff Trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash when using logger at Debug level
2 participants
@mathomp4 @tclune