Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix double timers #472

Merged
merged 1 commit into from
Jun 26, 2020
Merged

fix double timers #472

merged 1 commit into from
Jun 26, 2020

Conversation

weiyuan-jiang
Copy link
Contributor

@weiyuan-jiang weiyuan-jiang commented Jun 25, 2020 •
edited
Loading

Address issue #469 .

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@weiyuan-jiang weiyuan-jiang added 🪲 Bugfix This fixes a bug! 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. labels Jun 25, 2020
@weiyuan-jiang weiyuan-jiang requested a review from a team as a code owner June 25, 2020 20:48
atrayano
atrayano reviewed Jun 25, 2020
View reviewed changes
Copy link
Contributor

@atrayano atrayano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks OK to me, but I defer to Tom for final aproval

@tclune
Copy link
Collaborator

tclune commented Jun 26, 2020

@weiyuan-jiang can you post a snippet of the profiler output for evidence in the ticket?

@weiyuan-jiang
Copy link
Contributor Author

The snippet was post in the issue #469

@weiyuan-jiang weiyuan-jiang merged commit f5ab59a into main Jun 26, 2020
@weiyuan-jiang weiyuan-jiang deleted the hotfix/wjiang/#469_double_timer branch June 26, 2020 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atrayano atrayano atrayano left review comments

@tclune tclune tclune approved these changes

Assignees
No one assigned
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 🪲 Bugfix This fixes a bug!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@weiyuan-jiang @tclune @atrayano