Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add step size for average sun angle #35

Merged
merged 3 commits into from
Sep 5, 2019
Merged

add step size for average sun angle #35

merged 3 commits into from
Sep 5, 2019

Conversation

weiyuan-jiang
Copy link
Contributor

No description provided.

@weiyuan-jiang weiyuan-jiang requested a review from a team as a code owner September 4, 2019 13:30
tclune
tclune reviewed Sep 4, 2019
View reviewed changes
Copy link
Collaborator

@tclune tclune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Shouldn't this be a PR onto develop rather than master?
  2. I want @atrayano to look at this. Our high res model is already taking steps smaller than 300s, so I'm surprised at the existing logic.

@weiyuan-jiang
Copy link
Contributor Author

I didn't see "Our high res model is already taking steps smaller than 300s". GEOSldas needs control of the step size. Now I pull request both on master and develop branch

@weiyuan-jiang weiyuan-jiang requested a review from a team as a code owner September 5, 2019 13:43
atrayano
atrayano approved these changes Sep 5, 2019
View reviewed changes
Copy link
Contributor

@atrayano atrayano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks OK

@bena-nasa bena-nasa merged commit c9c3477 into master Sep 5, 2019
@bena-nasa bena-nasa deleted the feature/avg_sun_stepsize branch September 5, 2019 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tclune tclune tclune left review comments

@bena-nasa bena-nasa bena-nasa approved these changes

@atrayano atrayano atrayano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@weiyuan-jiang @tclune @bena-nasa @atrayano