Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ALIAS column to ACG StateSpec files #3379

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

darianboggs
Copy link
Contributor

Types of change(s)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)
  • Refactor (no functional changes, no api changes)

Checklist

  • Tested this change with a run of GEOSgcm
  • Ran the Unit Tests (make tests)

Description

This PR adds the capability to the automatic code generator (ACG) to give an alternate name to the pointer variable in the pointer declaration and MAPL_GetPointer call for a variable spec. The default behavior is to create a pointer variable FOO for a variable spec with short_name=FOO. If the ALIAS column is added to the ACG StateSpec file and the value for a row is not blank, that value is used for the pointer variable if the -d and/or -g options are included in the ACG call.

This PR was created in response to variable specs that include the same NAME (short_name) for variables in two categories (eg. IMPORT and EXPORT). It creates a more general capability to name the pointer variable.

@darianboggs darianboggs added 🎁 New Feature This is a new feature 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. labels Feb 3, 2025
@darianboggs darianboggs self-assigned this Feb 3, 2025
@darianboggs darianboggs marked this pull request as ready for review February 4, 2025 15:16
@darianboggs darianboggs requested a review from a team as a code owner February 4, 2025 15:16
@tclune tclune merged commit 5badf8d into develop Feb 4, 2025
58 checks passed
@tclune tclune deleted the feature/wdboggs/acg_ptr_alias branch February 4, 2025 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 🎁 New Feature This is a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants