Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #3369 #3370

Merged
merged 2 commits into from
Jan 28, 2025
Merged

fixes #3369 #3370

merged 2 commits into from
Jan 28, 2025

Conversation

bena-nasa
Copy link
Collaborator

Fixes issue #3369

Types of change(s)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)
  • Refactor (no functional changes, no api changes)

Checklist

  • Tested this change with a run of GEOSgcm
  • Ran the Unit Tests (make tests)

Description

Related Issue

@bena-nasa bena-nasa added 🪲 Bugfix This fixes a bug! 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. labels Jan 28, 2025
@bena-nasa bena-nasa requested a review from a team as a code owner January 28, 2025 18:53
@weiyuan-jiang
Copy link
Contributor

I remember I used the non-collective call to get the coords. If it can't be use any more, then the call here may have problem too.
(

call ESMF_GridGetCoord(grid,coordDim=1, localDe=0, &
staggerloc=ESMF_STAGGERLOC_CORNER, fArrayPtr = lons, _RC)
call ESMF_GridGetCoord(grid,coordDim=2, localDe=0, &
staggerloc=ESMF_STAGGERLOC_CORNER, fArrayPtr = lats, _RC)
)

@bena-nasa
Copy link
Collaborator Author

bena-nasa commented Jan 28, 2025

MAPL/base/Base/Base_Base_implementation.F90

Do we have a use case that even uses this non cubed-sphere branch? I agree that if we had non-cubed sphere mini-grids this would be a problem, but to my knowledge this is not a use case right now. I guess I could fix it to use the MAPL version of this call.

@tclune tclune merged commit c7bdfa3 into main Jan 28, 2025
48 checks passed
@tclune tclune deleted the hotfix/bmauer/fixes-#3369 branch January 28, 2025 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 🪲 Bugfix This fixes a bug!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants