Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trajectory sampler: use a single obs file at each Epoch time and restore obs location for output #3326

Merged
merged 19 commits into from
Jan 16, 2025

Conversation

metdyn
Copy link
Contributor

@metdyn metdyn commented Jan 15, 2025

Types of change(s)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)
  • Refactor (no functional changes, no api changes)

Checklist

  • Tested this change with a run of GEOSgcm
  • Ran the Unit Tests (make tests)

Description

This PR continues #3279 (comment)

The trajectory sampler netCDF output variable location_index_in_iodafile can now be turned off, after we add two control variables: use_NWP_1_file and restore_2_obs_vector for users.

  1. when use_NWP_1_file = .true., code reads in a single obs file for each epoch
  2. when restore_2_obs_vector = .true., code restores obs locations as input IODA file, the previous remapping ioda index is suppressed.

Related Issue

I have anther PR on splitfield for sampler to be merged to this PR, which handles
jedi.splitField: 1

Test performed:

  1. ExtData run for 3 days with input

jedi.use_NWP_1_file: .true.
jedi.restore_2_obs_vector: .true.
jedi.ObsPlatforms: aircraft airs_aqua amsr2_gcom-w1 amsua_aqua amsua_metop-b amsua_n15 amsua_n18 amsua_n19 atms_n20 atms_npp avhrr3_metop-b avhrr3_n18 avhrr3_n19 cris-fsr_n20 cris-fsr_npp gmi_gpm gps iasi_metop-b mhs_metop-b mhs_n19 mls55_aura omi_aura ompsnm_npp satwind scatwind sfc sfcship sondes ssmis_f17

input datetime (netcdf sondes.20190802T210000Z)
dateTime = 1564787773, 1564787771, 1564787771, 1564787805, 1564787805,
1564787872, 1564787882, 1564787886, 1564787889, 1564787891, 1564787898,
...
1564792640, 1564792601, 1564789326, 1564789326, 1564792502, 1564792501,
1564792437, 1564792374 ;

output: netcdf sondes.jedi.20190802_2100z
dateTime = 1564787773, 1564787771, 1564787771, 1564787805, 1564787805,
1564787872, 1564787882, 1564787886, 1564787889, 1564787891, 1564787898,
...
1564792640, 1564792601, 1564789326, 1564789326, 1564792502, 1564792501,
1564792437, 1564792374 ;

input:
longitude = 351.33, 351.33, 351.33, 351.3301, 351.3301, 351.335, 351.3365,
351.3372, 351.3378, 351.3381, 351.3395, 351.3398, 351.3402, 351.3409,
...
125.6533, 125.6533, 125.6533, 125.6533, 125.6533, 125.6533, 125.6533,
125.6533 ;

output:
longitude = 351.329956054688, 351.329986572266, 351.329986572266,
351.330139160156, 351.330139160156, 351.335021972656, 351.336547851562,
...
125.653289794922, 125.653289794922, 125.653289794922, 125.653289794922,
125.653289794922, 125.653289794922 ;

metdyn added 18 commits January 2, 2025 15:09
…t location_index for IODA file exact match the single input NPW observation file

default use_NWP_1_file=0 recovers the strict Time interval cut stratgy as python [T1, T1+Epoch).
-                  call this%obs(k)%file_handle%put_var(this%var_name_time, real(this%obs(k)%times_R8), &
+                  call this%obs(k)%file_handle%put_var(this%var_name_time, this%obs(k)%times_R8, &
effect:
 dateTime = 1559357952, 1559357952, 1559357952, 1559357952, 1559357952,
Vs
 dateTime = 1559358000, 1559358000, 1559358000, 1559358000, 1559358000,
  jedi.restore_2_obs_vector: .true.
will generate netCDF output that restores obs locations as in IODA file
@metdyn metdyn added the 0 Diff Trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) label Jan 15, 2025
@metdyn metdyn requested a review from a team as a code owner January 15, 2025 19:01
tclune
tclune previously approved these changes Jan 15, 2025
@mathomp4 mathomp4 merged commit 45bdba5 into develop Jan 16, 2025
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff Trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants