Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added subroutine to read NC4 tile file #3321

Merged
merged 3 commits into from
Jan 16, 2025
Merged

Added subroutine to read NC4 tile file #3321

merged 3 commits into from
Jan 16, 2025

Conversation

weiyuan-jiang
Copy link
Contributor

@weiyuan-jiang weiyuan-jiang commented Jan 15, 2025 •
edited
Loading

Types of change(s)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)
  • Refactor (no functional changes, no api changes)

Checklist

  • Tested this change with a run of GEOSgcm
  • Ran the Unit Tests (make tests)

Description

Preparing for the nc4 tile file

Related Issue

@weiyuan-jiang weiyuan-jiang self-assigned this Jan 15, 2025
@weiyuan-jiang weiyuan-jiang added the 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. label Jan 15, 2025
@weiyuan-jiang weiyuan-jiang marked this pull request as ready for review January 15, 2025 19:44
@weiyuan-jiang weiyuan-jiang requested a review from a team as a code owner January 15, 2025 19:44
tclune
tclune approved these changes Jan 16, 2025
View reviewed changes
Copy link
Collaborator

@tclune tclune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of repeated structure here, but I don't readily see a mechanism to significantly simplify.

@mathomp4 mathomp4 merged commit 76f3be0 into develop Jan 16, 2025
48 checks passed
@mathomp4 mathomp4 deleted the feature/wjiang/read_nc4_tile branch January 16, 2025 18:03
@github-actions github-actions bot mentioned this pull request Jan 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathomp4 mathomp4 mathomp4 left review comments

@tclune tclune tclune approved these changes

Assignees

@weiyuan-jiang weiyuan-jiang

Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@weiyuan-jiang @mathomp4 @tclune