Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI changes for GEOSadas #3197

Merged
merged 1 commit into from
Nov 27, 2024
Merged

CI changes for GEOSadas #3197

merged 1 commit into from
Nov 27, 2024

Conversation

mathomp4
Copy link
Member

Types of change(s)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)
  • Refactor (no functional changes, no api changes)

Checklist

  • Tested this change with a run of GEOSgcm
  • Ran the Unit Tests (make tests)

Description

For reasons I can't quite figure out now, the debug build of GEOSadas in CI is just...having issues. I can't duplicate on discover, so I'm stuck. But, I also realized that we don't build GEOSadas as Debug anyway in reality, so let's build GEOSadas in CI as we do in real life as Release.

I think this fixes the issue!

Related Issue

@mathomp4 mathomp4 added 0 Diff Trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) 🔧 Github Actions Automatic or GitHub Actions labels Nov 27, 2024
@mathomp4 mathomp4 self-assigned this Nov 27, 2024
@mathomp4 mathomp4 requested a review from a team as a code owner November 27, 2024 15:38
@mathomp4 mathomp4 merged commit fc85e4c into develop Nov 27, 2024
45 checks passed
@mathomp4 mathomp4 deleted the bugfix/mathomp4/adas-ci-fix branch November 27, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff Trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) 🔧 Github Actions Automatic or GitHub Actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants