Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #3131 #3132

Merged
merged 2 commits into from
Oct 29, 2024
Merged

fixes #3131 #3132

merged 2 commits into from
Oct 29, 2024

Conversation

bena-nasa
Copy link
Collaborator

Fixes issue #3131
Appeared to only affect Ricardo in GEOSagcmPert.x and caused a timer to be turned on but not off causing issues up the chain in MAPL_Generic

Types of change(s)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)
  • Refactor (no functional changes, no api changes)

Checklist

  • Tested this change with a run of GEOSgcm
  • Ran the Unit Tests (make tests)

Description

Related Issue

@bena-nasa bena-nasa added 🪲 Bugfix This fixes a bug! 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. labels Oct 28, 2024
@bena-nasa bena-nasa requested a review from a team as a code owner October 28, 2024 20:49
tclune
tclune previously approved these changes Oct 29, 2024
@mathomp4
Copy link
Member

I've borrowed this PR to get it into shape for a release.

@tclune tclune merged commit 306ca39 into main Oct 29, 2024
34 of 36 checks passed
@tclune
Copy link
Collaborator

tclune commented Oct 29, 2024

Oops - I missed Matt's comment. I just was trying to reduce number of open PR's and saw that it was ready.

@mathomp4 mathomp4 deleted the hotfix/bmauer/fixes-#3131 branch October 31, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 🪲 Bugfix This fixes a bug!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants