-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow update offsets based on timestep for extdata2g #3099
Merged
darianboggs
merged 17 commits into
develop
from
feature/wdboggs/#3064_variant_spec_offset_extdata2g
Oct 17, 2024
Merged
Allow update offsets based on timestep for extdata2g #3099
darianboggs
merged 17 commits into
develop
from
feature/wdboggs/#3064_variant_spec_offset_extdata2g
Oct 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bena-nasa
reviewed
Oct 16, 2024
bena-nasa
previously approved these changes
Oct 16, 2024
@bena-nasa and @tclune I added two tests to check if the result from using Also, I added the capacity to include a |
bena-nasa
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
0 Diff
The changes in this pull request have verified to be zero-diff with the target branch.
🎁 New Feature
This is a new feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of change(s)
Checklist
make tests
)Description
Currently, the YAML configuration file for ExtData2 allows an offset for updates using an ISO8601 time duration string, such at
T09:00:00
. A user requested the capability to specify the offset as (+/-) timestep. This PR implements that capability. If map value for theupdate_offset
isHEARTBEAT
, the offset is set to anESMF_TimeInterval
equal to 1 timestep. If the map value is-HEARTBEAT
, the offset is set to anESMF_TimeInterval
equal to -1 timestep. This may be extended to allow offsets of ±n timestep
, where is a natural number.Related Issue
resolve #3064