Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow update offsets based on timestep for extdata2g #3099

Merged

Conversation

darianboggs
Copy link
Contributor

Types of change(s)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)
  • Refactor (no functional changes, no api changes)

Checklist

  • Tested this change with a run of GEOSgcm
  • Ran the Unit Tests (make tests)

Description

Currently, the YAML configuration file for ExtData2 allows an offset for updates using an ISO8601 time duration string, such at T09:00:00. A user requested the capability to specify the offset as (+/-) timestep. This PR implements that capability. If map value for the update_offset is HEARTBEAT, the offset is set to an ESMF_TimeInterval equal to 1 timestep. If the map value is -HEARTBEAT, the offset is set to an ESMF_TimeInterval equal to -1 timestep. This may be extended to allow offsets of ±n timestep, where is a natural number.

Related Issue

resolve #3064

@darianboggs darianboggs added the 🎁 New Feature This is a new feature label Oct 16, 2024
@darianboggs darianboggs requested a review from a team as a code owner October 16, 2024 03:51
@darianboggs darianboggs added the 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. label Oct 16, 2024
bena-nasa
bena-nasa previously approved these changes Oct 16, 2024
@darianboggs
Copy link
Contributor Author

@bena-nasa and @tclune I added two tests to check if the result from using HEARTBEAT (string) matches the result from using ISO8601 Duration (string). They match for positive and negative HEARTBEAT.

Also, I added the capacity to include a + in front of the update_offset string. With the capability to use HEARTBEAT, I forsee a user using +HEARTBEAT, and I'd rather fix it now.

@mathomp4 mathomp4 requested a review from bena-nasa October 17, 2024 13:33
@darianboggs darianboggs requested a review from bena-nasa October 17, 2024 13:43
@darianboggs darianboggs merged commit b8283be into develop Oct 17, 2024
36 checks passed
@darianboggs darianboggs deleted the feature/wdboggs/#3064_variant_spec_offset_extdata2g branch October 17, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 🎁 New Feature This is a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants