Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn off zstandard with Baselibs #3098

Merged
merged 5 commits into from
Oct 17, 2024
Merged

Conversation

mathomp4
Copy link
Member

Types of change(s)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)
  • Refactor (no functional changes, no api changes)

Checklist

  • Tested this change with a run of GEOSgcm
  • Ran the Unit Tests (make tests)

Description

As found by @bena-nasa, Bucy is showing Baselibs supports zstandard compression because, I guess, HDF5 or netCDF or something found it. But, since Baselibs builds HDF5 and netCDF as static libraries, Baselibs can never run zstandard code. So, by fiat, if Baselibs is used, we just turn off zstandard.

Also, for consistency, set the ESMF required version in Baselibs builds to match that of Spack.

Related Issue

@mathomp4 mathomp4 added the 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. label Oct 15, 2024
@mathomp4 mathomp4 self-assigned this Oct 15, 2024
@mathomp4 mathomp4 requested a review from a team as a code owner October 15, 2024 18:47
@mathomp4
Copy link
Member Author

I was able to test on Bucy and I needed a fix. (Had to FORCE the false on.). But it works for me.

@mathomp4 mathomp4 merged commit 0d6ce1a into develop Oct 17, 2024
34 of 36 checks passed
@mathomp4 mathomp4 deleted the bugfix/mathomp4/zstandard-on-bucy branch October 17, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants