Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to ecbuild geos/v1.4.0 #3066

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Update to ecbuild geos/v1.4.0 #3066

merged 1 commit into from
Oct 3, 2024

Conversation

mathomp4
Copy link
Member

@mathomp4 mathomp4 commented Oct 3, 2024

Types of change(s)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)
  • Refactor (no functional changes, no api changes)

Checklist

  • Tested this change with a run of GEOSgcm
  • Ran the Unit Tests (make tests)

Description

As found by @tclune and @gmao-ckung, XCode 16 on macOS has caused an issue where the -pipe GNU compiler flag causes errors in CMake builds.

It doesn't seem to be crucial and research online says the pipe flag isn't really that crucial for fast builds anymore.

Related Issue

@mathomp4 mathomp4 added the 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. label Oct 3, 2024
@mathomp4 mathomp4 self-assigned this Oct 3, 2024
@mathomp4 mathomp4 requested a review from a team as a code owner October 3, 2024 16:01
@tclune tclune merged commit 9626210 into develop Oct 3, 2024
40 checks passed
@mathomp4 mathomp4 deleted the feature/mathomp4/update-ecbuild-mapl branch October 3, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tclune tclune tclune approved these changes

Assignees

@mathomp4 mathomp4

Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mathomp4 @tclune