Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/bmauer/containers extdata2g #3007

Merged
merged 3 commits into from
Sep 6, 2024

Conversation

bena-nasa
Copy link
Collaborator

@bena-nasa bena-nasa commented Sep 6, 2024

Another baby step in prep for vertical regridding in ExtData2G. In this I have replaced an allocatable array with a container so that I can easily add more primary items if needed (PS variables from files for vertical regridding) later in initialization. The current implementation that allocated a pointer array would not work, the list needed to be extended later.

I more made this to see if gnu threw any errors. And yes, I've commented out some code, that will either go away or change, by no means do I mean for that to stay that way.

Types of change(s)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)
  • Refactor (no functional changes, no api changes)

Checklist

  • Tested this change with a run of GEOSgcm
  • Ran the Unit Tests (make tests)

Description

Related Issue

@bena-nasa bena-nasa added 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 🛠️ Refactor This is code refactoring labels Sep 6, 2024
@bena-nasa bena-nasa requested a review from a team as a code owner September 6, 2024 15:15
@bena-nasa bena-nasa merged commit fbdab2d into develop Sep 6, 2024
38 checks passed
@bena-nasa bena-nasa deleted the feature/bmauer/containers_extdata2g branch September 6, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 🛠️ Refactor This is code refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants