Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changes needed for R21C #2685

Merged
merged 2 commits into from
Mar 28, 2024
Merged

changes needed for R21C #2685

merged 2 commits into from
Mar 28, 2024

Conversation

bena-nasa
Copy link
Collaborator

@mathomp4 Just making this PR to R21C with the deflate changes they want. I guess it needs to be merged and a new tag made

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@bena-nasa bena-nasa added 🎁 New Feature This is a new feature 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. labels Mar 27, 2024
@bena-nasa bena-nasa requested a review from a team as a code owner March 27, 2024 20:23
@mathomp4
Copy link
Member

@bena-nasa Can you update the changelog?

@mathomp4
Copy link
Member

Ugggggh. I think I need to fix up the CI in here. One moment...

@mathomp4
Copy link
Member

I also updated the changelog. But now to see how the CI does...

@mathomp4 mathomp4 merged commit edc5213 into R21C Mar 28, 2024
11 checks passed
@mathomp4 mathomp4 deleted the feature/bmauer/R21C_backport_deflate branch March 28, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atrayano atrayano atrayano approved these changes

Assignees
No one assigned
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 🎁 New Feature This is a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bena-nasa @mathomp4 @atrayano