Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ESSENTIAL label #2659

Merged
merged 7 commits into from
Apr 1, 2024
Merged

Add ESSENTIAL label #2659

merged 7 commits into from
Apr 1, 2024

Conversation

mathomp4
Copy link
Member

@mathomp4 mathomp4 commented Mar 18, 2024

Description

This PR adds an ESSENTIAL label to many tests in MAPL. These are the "small" tests as it were. So it avoids the:

  • PERFORMANCE
  • EXTDATA1G_BIG_TESTS
  • EXTDATA2G_BIG_TESTS

tests. This change along with ESMA_cmake v3.43.0 (which this PR also updates to), means that when a user does make tests only the ESSENTIAL tests are run.

To run all the tests do make tests-all

Also, update to ESMA_env v4.25.1 to match GEOSgcm

Related Issue

Motivation and Context

Makes testing MAPL on smaller machines a bit easier.

How Has This Been Tested?

It worked on discover. make tests doesn't run all the tests now.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@mathomp4 mathomp4 added the 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. label Mar 18, 2024
@mathomp4 mathomp4 self-assigned this Mar 18, 2024
@mathomp4 mathomp4 requested review from a team as code owners March 18, 2024 20:42
@mathomp4 mathomp4 merged commit a0eef52 into develop Apr 1, 2024
31 checks passed
@mathomp4 mathomp4 deleted the feature/mathomp4/essential-tests branch April 1, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants