Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remove attribute procedure to FileMetadata #2626

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

bena-nasa
Copy link
Collaborator

In the interp_restart code, to produce the output file I "cheat". Basically load the input file and produce a fileMetadata object from it. I then copy this to a new fileMetadata object and change the dimensions in object. Then I can use this to produce the new file.

The problem is that if the input is stretched but the output is not, @wmputman found that the stretching parameters were getting into the output file in his new updated inpterp_restarts.x version that can handle both and input and/or output stretched grid. So I needed a procedure to remove them if needed before writing.

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@bena-nasa bena-nasa added 🎁 New Feature This is a new feature 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. labels Feb 28, 2024
@bena-nasa bena-nasa requested a review from a team as a code owner February 28, 2024 19:17
@bena-nasa bena-nasa requested a review from tclune February 28, 2024 19:17
@mathomp4 mathomp4 merged commit 661fb2a into develop Feb 28, 2024
37 checks passed
@mathomp4 mathomp4 deleted the feature/bmauer/remove_attributes_metadata branch February 28, 2024 23:11
@tclune
Copy link
Collaborator

tclune commented Mar 4, 2024

Longer term is there an option to simply pass a correct metadata object when creating the new file? This seems kludgy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 🎁 New Feature This is a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants