Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/atrayano/io fixes #2592

Merged
merged 3 commits into from
Feb 9, 2024
Merged

Feature/atrayano/io fixes #2592

merged 3 commits into from
Feb 9, 2024

Conversation

atrayano
Copy link
Contributor

@atrayano atrayano commented Feb 9, 2024

Description

This implements necessary changes to run high resolutions on SCU17. Implements more efficient tile file reads and eliminates unnecessary memory allocations (for 1d vars)

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [ x] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • [x ] I have tested this change with a run of GEOSgcm (if non-trivial)
  • [x ] I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • [x ] I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@atrayano
Hand merge with the difference beween the last two commits on
18c70e5 
feature/atrayano/updates-for-milan brancsh (as of Nov-24-2023) with
develop. This is to eliminate unnnecessary allocation during checkpoint
writes and a different algorith for the tile restarts
@atrayano
Merge branch 'develop' into feature/atrayano/io_fixes
63bc714
@atrayano
Implements more efficient reading of tile files
28c6151
@atrayano atrayano added the 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. label Feb 9, 2024
@atrayano atrayano requested review from tclune and bena-nasa February 9, 2024 01:10
@atrayano atrayano self-assigned this Feb 9, 2024
@atrayano atrayano requested a review from a team as a code owner February 9, 2024 01:10
@tclune tclune merged commit 10c5e2f into develop Feb 9, 2024
33 checks passed
@tclune tclune deleted the feature/atrayano/io_fixes branch February 9, 2024 16:06
@mathomp4 mathomp4 mentioned this pull request Feb 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tclune tclune tclune approved these changes

@bena-nasa bena-nasa Awaiting requested review from bena-nasa

Assignees

@atrayano atrayano

Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atrayano @tclune