Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed a memory leak affecting regional masking #2571

Merged
merged 2 commits into from
Feb 6, 2024
Merged

Fixed a memory leak affecting regional masking #2571

merged 2 commits into from
Feb 6, 2024

Conversation

atrayano
Copy link
Contributor

@atrayano atrayano commented Feb 6, 2024 •
edited by mathomp4
Loading

Fixes memory leak afection regional masking

Description

Several temporary ESMF fields were created but never destroyed. This PR adds the missing "ESMF_FieldDestroy

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@atrayano atrayano added 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. bugfix labels Feb 6, 2024
@atrayano atrayano requested a review from tclune February 6, 2024 14:22
@atrayano atrayano self-assigned this Feb 6, 2024
@atrayano atrayano requested a review from a team as a code owner February 6, 2024 14:22
tclune
tclune reviewed Feb 6, 2024
View reviewed changes
@mathomp4 mathomp4 merged commit fd15ea5 into main Feb 6, 2024
27 checks passed
@mathomp4 mathomp4 deleted the hotfix/atrayano/mem_leak_masking branch February 6, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tclune tclune tclune approved these changes

Assignees

@atrayano atrayano

Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@atrayano @tclune @mathomp4