Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add message to oserver-root even it is 0-sized #2559

Merged
merged 1 commit into from
Jan 29, 2024
Merged

add message to oserver-root even it is 0-sized #2559

merged 1 commit into from
Jan 29, 2024

Conversation

weiyuan-jiang
Copy link
Contributor

@weiyuan-jiang weiyuan-jiang commented Jan 29, 2024 •
edited
Loading

add message to oserver-root even it is 0-sized
This PR fixes the issue #2557

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@weiyuan-jiang weiyuan-jiang requested a review from a team as a code owner January 29, 2024 16:27
@weiyuan-jiang weiyuan-jiang added 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. bugfix labels Jan 29, 2024
@tclune tclune merged commit fd22e95 into main Jan 29, 2024
40 of 41 checks passed
@tclune tclune deleted the bugfix/wjiang/add_0size_message branch January 29, 2024 17:22
@bena-nasa bena-nasa mentioned this pull request Jan 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tclune tclune tclune approved these changes

Assignees
No one assigned
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weiyuan-jiang @tclune