Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Ninja Builds of GEOS in CI #2517

Merged
merged 3 commits into from
Jan 5, 2024
Merged

Enable Ninja Builds of GEOS in CI #2517

merged 3 commits into from
Jan 5, 2024

Conversation

mathomp4
Copy link
Member

@mathomp4 mathomp4 commented Jan 3, 2024 •
edited
Loading

Description

Enables ninja builds of MAPL in our CI system. This is useful as Ninja is slowly becoming the build system of choice for some and ninja can also detect circular dependencies better than GNU Make as well.

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@mathomp4 mathomp4 added the 0 Diff Trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) label Jan 3, 2024
@mathomp4 mathomp4 self-assigned this Jan 3, 2024
@mathomp4 mathomp4 changed the title Enable Ninja in CI Enable Ninja Builds of GEOS in CI Jan 4, 2024
@mathomp4 mathomp4 marked this pull request as ready for review January 4, 2024 17:51
@mathomp4 mathomp4 requested a review from a team as a code owner January 4, 2024 17:51
tclune
tclune previously approved these changes Jan 5, 2024
View reviewed changes
@mathomp4 mathomp4 requested a review from a team January 5, 2024 20:05
@mathomp4 mathomp4 merged commit 205f3e7 into develop Jan 5, 2024
8 checks passed
@mathomp4 mathomp4 deleted the feature/mathomp4/enable-ninja-ci branch January 5, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bena-nasa bena-nasa bena-nasa approved these changes

@tclune tclune tclune left review comments

Assignees

@mathomp4 mathomp4

Labels
0 Diff Trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mathomp4 @tclune @bena-nasa