-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swath grid for MAPL_HistoryGridComp #2458
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modifications made to GriddedIO.F90, MAPL_AbstractRegridder.F90, and MAPL_EsmfRegridder.F90.
nf90_getvar from mod04/Data Fields/Scan_Start_Time netCDF error: NetCDF: Start+count exceeds dimension bound
- I seem to find some config problems related to the position history.rc entries are laid out in file. - File names needs to be in template, - Stick to every 5 minute inteval for template
- DOY - cmd=bash -c 'ls /Users/yyu11/ModelData/earthData/flk_modis_MOD04_2017_090/MOD04_L2.A2017090.0010.*.hdf' &> zzz_MAPL
Fatal Error: /Users/yyu11/repos/br_mapl_traj_all_compilers/MAPL/base/FileMetadataUtilities.F90, line 5: Cannot find module MAPL_GRIDMANAGERMOD detected at MAPL_GRIDMANAGERMOD@<end-of-statement> Next merge develop to see if this can solve the problem.
Suspect griddedio.F90 problem, like what is modified by Ben.
- ArrayReference in stage2DLatLon in GriddedIO.F90 generates strange values in netCDF ?? - Why case4 works with NAG ?
tclune
reviewed
Nov 30, 2023
tclune
reviewed
Nov 30, 2023
tclune
reviewed
Nov 30, 2023
tclune
reviewed
Nov 30, 2023
tclune
requested changes
Nov 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a lot here so I mostly did spot checks. There are 1-2 items that should be addressed and maybe 1-2 more that could be, but are not as crucial.
tclune
previously approved these changes
Nov 30, 2023
tclune
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Creating Swath grid from observation files such as modis_MOD04_L2 data. In history grid component, use ESMF to regrid from cubed sphere grid to this logically rectangular grid.
Coauthor with Tom, Ben and Arlindo. Epoch time frame is introduced to select a chunk of observation based on user specification. Code can regrid and accumulate at each model run step, then use griddedIO to stage the data to the oserver.
Swath grid is regenerated for each Epoch time (e.g., 6 hour).
Code allows for observation file name template with wild-character (e.g., modis_*.nc4) and can skip missing observation file.
I should add Tom also solved the issue with NAG netCDF (lons/lats output problem in this PR): #2380
Example input:
Output:
var2d and var3d in
modis_swath.20170331_0300.nc4
Related Issue
Motivation and Context
How Has This Been Tested?
var2d = 100*cos(lons)*cos(lats)
Checked the history output with nccmp and ncdump results.
They are identical. This means the modifications to GriddedIO.F90 and other codes do not introduce output difference in history.
diff d.c12_control_Nov1.geosgcm_prog.20000415_1800z d.c12_swath_PR2_test.geosgcm_prog.20000415_1800z.
> netcdf c12_control_Nov1.geosgcm_prog.20000415_1800z
< netcdf c12_swath_PR2_test.geosgcm_prog.20000415_1800z
204,205c204,205
> :Source = "GEOSgcm-v11.3.2 experiment_id: c12_control_Nov1" ;
< :Title = "a" ;
> :Source = "GEOSgcm-v11.3.2 experiment_id: c12_swath_PR2_test" ;
> :Title = "test_SWATH_PR2_with_C12" ;
Types of changes
Checklist: