Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/bmauer/fixes #2418 #2419

Merged
merged 3 commits into from
Oct 27, 2023
Merged

Feature/bmauer/fixes #2418 #2419

merged 3 commits into from
Oct 27, 2023

Conversation

bena-nasa
Copy link
Collaborator

Fixes #2418
This was needed to fix an issue @sdrabenh found with replay and the write_by_oserver, which is the default with openmpi

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@bena-nasa bena-nasa added 🎁 New Feature This is a new feature 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. labels Oct 26, 2023
@bena-nasa bena-nasa requested a review from a team as a code owner October 26, 2023 20:32
tclune
tclune approved these changes Oct 26, 2023
View reviewed changes
Copy link
Collaborator

@tclune tclune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All those if (have_oclients) screams for a subclass. But ... not now.

@mathomp4 mathomp4 merged commit 70db11f into develop Oct 27, 2023
@mathomp4 mathomp4 deleted the feature/bmauer/fixes-#2418 branch October 27, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tclune tclune tclune approved these changes

Assignees
No one assigned
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 🎁 New Feature This is a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bena-nasa @tclune @mathomp4