Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #2398 #2399

Merged
merged 2 commits into from
Oct 4, 2023
Merged

Fixes #2398 #2399

merged 2 commits into from
Oct 4, 2023

Conversation

bena-nasa
Copy link
Collaborator

Fixes #2398

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@bena-nasa bena-nasa added 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. bugfix labels Oct 4, 2023
@bena-nasa bena-nasa requested a review from a team as a code owner October 4, 2023 15:28
@bena-nasa bena-nasa requested review from atrayano and tclune October 4, 2023 15:40
@mathomp4 mathomp4 requested a review from a team as a code owner October 4, 2023 16:10
mathomp4
mathomp4 approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@mathomp4 mathomp4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to run for me in a c24 run.

@bena-nasa bena-nasa merged commit d1cdaa4 into main Oct 4, 2023
@mathomp4 mathomp4 deleted the hotfix/bmauer/fixes-#2398 branch October 4, 2023 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathomp4 mathomp4 mathomp4 approved these changes

@atrayano atrayano atrayano approved these changes

@tclune tclune Awaiting requested review from tclune

Assignees
No one assigned
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing return code checking when reading import restart
3 participants
@bena-nasa @mathomp4 @atrayano