Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get ExtDataDriver.x running on tiles #2246

Merged
merged 8 commits into from
Jul 20, 2023
Merged

Conversation

bena-nasa
Copy link
Collaborator

@bena-nasa bena-nasa commented Jul 19, 2023

This allows ExtDataDriver.x to work on "tile" grids and create the locstream on an attached grid and then create 'tileonly' variables which is precursor to getting ExtData able to ingest tile data and retire MAPL_ReadForcing. This will allow me to develop without having to run the full model.

Unfortunately do to a bug or limitation (which has been reported to ESMF) when doing ESMF_FIeldCreate on grids with ESMF_USER_INDEX, I had to redo the "clone" function in the field operation utilities to have MAPL, if the grid has was created with ESMF_USER_INDEX, rather than ESMF allocate the memory, we do, which of course brings the ugly rank/type logic we want to avoid. I'm very sorry about this but until ESMF either fixes the bug or removes the limitation this is what we must do and the way it must be, it just is.

I also updated and moved the field destroy that takes advantage of the fact ESMF now can report who allocated the memory so that I can destroy these fields no matter who allocated the memory.

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@bena-nasa bena-nasa added 🎁 New Feature This is a new feature 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. labels Jul 19, 2023
@bena-nasa bena-nasa requested a review from a team as a code owner July 19, 2023 15:19
@bena-nasa bena-nasa changed the title Feature/bmauer/fixes #2149 Get ExtDataDriver.x running on tiles Jul 19, 2023
Copy link
Collaborator

@tclune tclune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change requested. And some questions.

bena-nasa and others added 2 commits July 20, 2023 09:28
Co-authored-by: Tom Clune <thomas.l.clune@nasa.gov>
@bena-nasa
Copy link
Collaborator Author

Minor change requested. And some questions.

@tclune, turns out some external repos call "MAPL_FieldDestroy" so I should not have change the name to just "FieldDestroy", as I broke the public API which was causing the GEOSgcm build to fail.

@bena-nasa bena-nasa requested a review from tclune July 20, 2023 14:29
@tclune
Copy link
Collaborator

tclune commented Jul 20, 2023

Minor change requested. And some questions.

@tclune, turns out some external repos call "MAPL_FieldDestroy" so I should not have change the name to just "FieldDestroy", as I broke the public API which was causing the GEOSgcm build to fail.

OK - let's defer those kinds of changes until MAPL3. There we may use things like FieldDestroy internally, and then have a compatibility layer than uses rename to the explicit name.

I would hope destroying fields is very rare outside of MAPL though ...

@mathomp4 mathomp4 merged commit 6084c6c into develop Jul 20, 2023
@mathomp4 mathomp4 deleted the feature/bmauer/fixes-#2149 branch July 20, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 🎁 New Feature This is a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants