-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get ExtDataDriver.x running on tiles #2246
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor change requested. And some questions.
Co-authored-by: Tom Clune <thomas.l.clune@nasa.gov>
…ies use MAPL_FieldDestroy
@tclune, turns out some external repos call "MAPL_FieldDestroy" so I should not have change the name to just "FieldDestroy", as I broke the public API which was causing the GEOSgcm build to fail. |
OK - let's defer those kinds of changes until MAPL3. There we may use things like I would hope destroying fields is very rare outside of MAPL though ... |
This allows ExtDataDriver.x to work on "tile" grids and create the locstream on an attached grid and then create 'tileonly' variables which is precursor to getting ExtData able to ingest tile data and retire MAPL_ReadForcing. This will allow me to develop without having to run the full model.
Unfortunately do to a bug or limitation (which has been reported to ESMF) when doing ESMF_FIeldCreate on grids with ESMF_USER_INDEX, I had to redo the "clone" function in the field operation utilities to have MAPL, if the grid has was created with ESMF_USER_INDEX, rather than ESMF allocate the memory, we do, which of course brings the ugly rank/type logic we want to avoid. I'm very sorry about this but until ESMF either fixes the bug or removes the limitation this is what we must do and the way it must be, it just is.
I also updated and moved the field destroy that takes advantage of the fact ESMF now can report who allocated the memory so that I can destroy these fields no matter who allocated the memory.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist: