Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Logging config to Tests/ExtDataDriverMod.F90 #2175

Merged
merged 5 commits into from
Jun 16, 2023

Conversation

metdyn
Copy link
Contributor

@metdyn metdyn commented Jun 7, 2023

Description

This is only for bin/ExtDataDriver.x, without this addition the Logger is not enabled for ExtDataDriver.x, hence the print for logger debug would generate no output. (I find it a few months ago when printing debug info for station sampler)

Related Issue

Motivation and Context

How Has This Been Tested?

Tested by using Logger in station sampler to print debug results.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@metdyn metdyn requested review from mathomp4, tclune and bena-nasa June 7, 2023 23:10
@metdyn metdyn requested a review from a team as a code owner June 7, 2023 23:10
bena-nasa
bena-nasa previously approved these changes Jun 9, 2023
@metdyn
Copy link
Contributor Author

metdyn commented Jun 12, 2023 via email

@mathomp4 mathomp4 self-requested a review June 16, 2023 12:16
Copy link
Member

@mathomp4 mathomp4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approve due to update branch

@mathomp4 mathomp4 merged commit fdd1246 into develop Jun 16, 2023
@mathomp4 mathomp4 deleted the feature/ygyu/logging_config_to_extdriver branch June 16, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants