Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NetCDF C requirement to CMake #1578

Merged
merged 1 commit into from
Jun 23, 2022
Merged

Conversation

mathomp4
Copy link
Member

Description

As found by @climbfuji in JCSDA/spack#111 MAPL actually does have NetCDF C code. For some reason, their spack builds found this but mine didn't.

Still, it is plainly obvious we use NetCDF C so we must say so in our CMake!

Related Issue

Motivation and Context

Will let our NOAA-EMC friends not need to carry around a patch for future MAPL.

How Has This Been Tested?

This should only affect non-Baselibs builds so we should be good. I suppose we'll find out if this worked when @climbfuji updates MAPL!

I might also ping @weiyuan-jiang to try on Orion.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@mathomp4 mathomp4 added the 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. label Jun 23, 2022
@mathomp4 mathomp4 requested review from a team as code owners June 23, 2022 18:16
@mathomp4 mathomp4 self-assigned this Jun 23, 2022
@tclune tclune merged commit c651f90 into develop Jun 23, 2022
@tclune tclune deleted the bugfix/mathomp4/add-netcdf-c branch June 23, 2022 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants