Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update components.yaml to latest env and cmake #1572

Merged
merged 3 commits into from
Jun 17, 2022
Merged

Update components.yaml to latest env and cmake #1572

merged 3 commits into from
Jun 17, 2022

Conversation

mathomp4
Copy link
Member

Description

This updates MAPL to use the latest ESMA_env (3.14.0) and ESMA_cmake (3.17.0).

This brings in Baselibs 6.3.1 and is zero-diff.

Related Issue

Motivation and Context

Keeps MAPL up-to-date.

How Has This Been Tested?

I've built the model with these repos, so MAPL should work.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@mathomp4 mathomp4 added the 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. label Jun 16, 2022
@mathomp4 mathomp4 requested a review from a team as a code owner June 16, 2022 18:54
@mathomp4 mathomp4 self-assigned this Jun 16, 2022
tclune
tclune previously approved these changes Jun 16, 2022
View reviewed changes
@mathomp4
Copy link
Member Author

Well this is doubleplus ungood. Need to figure out how to get both LDAS and ADAS working... LDAS I think is simple, but ADAS...

@mathomp4
Copy link
Member Author

Okay. The ADAS should now work. I'll look at LDAS tomorrow.

@mathomp4 mathomp4 requested review from tclune and a team June 17, 2022 15:53
@mathomp4 mathomp4 merged commit c8ccd65 into develop Jun 17, 2022
@mathomp4 mathomp4 deleted the feature/mathomp4/update-components-mapl branch June 17, 2022 15:54
@mathomp4 mathomp4 mentioned this pull request Jun 17, 2022
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bena-nasa bena-nasa bena-nasa approved these changes

@tclune tclune Awaiting requested review from tclune

Assignees

@mathomp4 mathomp4

Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mathomp4 @tclune @bena-nasa