Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable bundleio tests in CI #1561

Merged
merged 2 commits into from
Jun 13, 2022
Merged

Conversation

mathomp4
Copy link
Member

Description

Thanks to #1559, we might be able to run the bundle io tests in CI again. This will test that.

Related Issue

Motivation and Context

More coverage in CI is a good thing.

How Has This Been Tested?

The test will be here

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@mathomp4 mathomp4 added the 0 Diff Trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) label Jun 13, 2022
@mathomp4 mathomp4 requested a review from a team as a code owner June 13, 2022 16:15
@mathomp4 mathomp4 self-assigned this Jun 13, 2022
atrayano
atrayano previously approved these changes Jun 13, 2022
@mathomp4
Copy link
Member Author

🎉

    Start  1: MAPL.pfio.tests
1/7 Test  #1: MAPL.pfio.tests ..................   Passed    1.70 sec
    Start  8: MAPL.profiler.tests
2/7 Test  #8: MAPL.profiler.tests ..............   Passed    0.58 sec
    Start  9: MAPL.generic.tests
3/7 Test  #9: MAPL.generic.tests ...............   Passed    0.32 sec
    Start 10: MAPL.shared.tests
4/7 Test #10: MAPL.shared.tests ................   Passed    0.02 sec
    Start 11: MAPL.base.tests
5/7 Test #11: MAPL.base.tests ..................   Passed    1.14 sec
    Start 12: bundleio_tests_latlon
6/7 Test #12: bundleio_tests_latlon ............   Passed    0.34 sec
    Start 13: bundleio_tests_cube
7/7 Test #13: bundleio_tests_cube ..............   Passed    0.68 sec

@mathomp4
Copy link
Member Author

Had to push an update as it looks like Open MPI has an issue with our bundleio cases:

      # NOTE: Currently Open MPI fails on the bundleio with:
      #
      #   The OSC pt2pt component does not support MPI_THREAD_MULTIPLE in this release.
      #   Workarounds are to run on a single node, or to use a system with an RDMA
      #   capable network such as Infiniband.
      #
      # For now, we run GNU/Open MPI without the bundleio tests. Some indications that
      # Open MPI 5 will not have this limitation

That said...we are running on a single node. 🤷🏼

I'll try and bring this up with Open MPI if it keeps happening with Open MPI 5 rather than focus on here.

@mathomp4 mathomp4 requested review from atrayano and a team June 13, 2022 17:23
@bena-nasa bena-nasa merged commit 3ef81a0 into develop Jun 13, 2022
@bena-nasa bena-nasa deleted the feature/mathomp4/enable-bundleio-ci branch June 13, 2022 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff Trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants