Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bundleio tests #1559

Merged
merged 1 commit into from
Jun 13, 2022
Merged

Fix bundleio tests #1559

merged 1 commit into from
Jun 13, 2022

Conversation

bena-nasa
Copy link
Collaborator

@bena-nasa bena-nasa commented Jun 13, 2022

This fixes these bundleio tests that a were added by Gian. The issues is that he calls two tests with the same executable. One exercises create a lat-lon file, the next exercises creating a cubed-sphere file. The problem is the executable uses a hard coded name for the temporary file created. So after say the lat-lon test runs, when the cube test runs the old lat-lon file from the previous test is still there. Since we do not clobber on creation (might want to revisit this) it tries to use the old existing lat-lon file and goes kaboom since it tries to write to a variable that does not exist.
So I just added the temporary file as an option to the command line for the testing program and use different files for the two tests.

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@bena-nasa bena-nasa added 0 Diff Trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) bugfix labels Jun 13, 2022
@bena-nasa bena-nasa requested review from a team as code owners June 13, 2022 14:50
@mathomp4 mathomp4 merged commit 40ba755 into develop Jun 13, 2022
@mathomp4
Copy link
Member

Now here's a new question (maybe for @tclune): Should we try enabling these in CI? Or are they not quite tests for CI? Still, I'll pull this in and maybe do an experiment to see if CircleCI is happy when I do.

@mathomp4 mathomp4 deleted the feature/bmauer/fix_bundleio_tests branch June 13, 2022 16:02
@mathomp4 mathomp4 mentioned this pull request Jun 13, 2022
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff Trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants