Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #1549 #1551

Merged
merged 2 commits into from
Jun 7, 2022
Merged

fixes #1549 #1551

merged 2 commits into from
Jun 7, 2022

Conversation

bena-nasa
Copy link
Collaborator

Fixes #1549
There was a bug in the non cubed-sphere grid path in MAPL_GetHorzIJIndex, in fact it was just not working which the scm exposed. This fixes that. @mathomp4 and I decided to do this "right" as a hotfix since it is a legit bug.

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@bena-nasa bena-nasa added 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. bugfix labels Jun 7, 2022
@bena-nasa bena-nasa requested a review from a team as a code owner June 7, 2022 17:16
@bena-nasa bena-nasa requested a review from tclune June 7, 2022 17:16
@bena-nasa bena-nasa requested a review from a team as a code owner June 7, 2022 17:29
@mathomp4 mathomp4 merged commit d46c2ed into main Jun 7, 2022
@mathomp4 mathomp4 deleted the hotfix/bmauer/fixes-#1549 branch June 7, 2022 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathomp4 mathomp4 mathomp4 approved these changes

@atrayano atrayano atrayano approved these changes

@tclune tclune Awaiting requested review from tclune

Assignees
No one assigned
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Possible MAPL Bug with SCM Debug
3 participants
@bena-nasa @mathomp4 @atrayano