Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1544. Adds _ASSERT for missing ExtData file #1545

Merged
merged 1 commit into from
Jun 6, 2022

Conversation

mathomp4
Copy link
Member

@mathomp4 mathomp4 commented Jun 6, 2022

Description

Added an inquire and _ASSERT for ExtData2G Yaml files so we trap the missing file ourselves.

Related Issue

Closes #1544

Motivation and Context

Uses our traceback rather than depending on the compiler.

How Has This Been Tested?

I ran GEOS with and without it. It crashes with our traceback if not found:

pe=00091 FAIL at line=00073    ExtDataConfig.F90                        <could not find: GEOSachem_ExtData.yaml>
pe=00091 FAIL at line=00087    ExtDataConfig.F90                        <status=1>
pe=00091 FAIL at line=00052    ExtDataOldTypesCreator.F90               <status=1>
pe=00092 FAIL at line=00073    ExtDataConfig.F90                        <could not find: GEOSachem_ExtData.yaml>
pe=00092 FAIL at line=00087    ExtDataConfig.F90                        <status=1>
pe=00092 FAIL at line=00052    ExtDataOldTypesCreator.F90               <status=1>
pe=00093 FAIL at line=00073    ExtDataConfig.F90                        <could not find: GEOSachem_ExtData.yaml>
pe=00093 FAIL at line=00087    ExtDataConfig.F90                        <status=1>
pe=00093 FAIL at line=00052    ExtDataOldTypesCreator.F90               <status=1>
pe=00094 FAIL at line=00073    ExtDataConfig.F90                        <could not find: GEOSachem_ExtData.yaml>
pe=00094 FAIL at line=00087    ExtDataConfig.F90                        <status=1>
pe=00094 FAIL at line=00052    ExtDataOldTypesCreator.F90               <status=1>
pe=00095 FAIL at line=00073    ExtDataConfig.F90                        <could not find: GEOSachem_ExtData.yaml>
pe=00095 FAIL at line=00087    ExtDataConfig.F90                        <status=1>
pe=00095 FAIL at line=00052    ExtDataOldTypesCreator.F90               <status=1>
pe=00093 FAIL at line=00353    ExtDataGridCompNG.F90                    <status=1>
pe=00091 FAIL at line=00353    ExtDataGridCompNG.F90                    <status=1>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@mathomp4 mathomp4 added the 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. label Jun 6, 2022
@mathomp4 mathomp4 requested a review from a team as a code owner June 6, 2022 17:50
@mathomp4 mathomp4 self-assigned this Jun 6, 2022
@mathomp4 mathomp4 requested review from tclune and bena-nasa June 6, 2022 17:50
@mathomp4
Copy link
Member Author

mathomp4 commented Jun 6, 2022

And, of course, if @bena-nasa can think of more places for things like this, please add.

@mathomp4 mathomp4 merged commit f6cf291 into develop Jun 6, 2022
@mathomp4 mathomp4 deleted the feature/mathomp4/1544-extdata2g-missing-file branch June 6, 2022 23:03
@mathomp4 mathomp4 linked an issue Jun 7, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better missing file traceback from ExtData2G
2 participants