Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to ESMA_cmake v3.16.0 #1540

Merged
merged 2 commits into from
Jun 3, 2022

Conversation

mathomp4
Copy link
Member

@mathomp4 mathomp4 commented Jun 3, 2022

Description

Updates the ESMA_cmake in MAPL to v3.16.0.

Related Issue

Motivation and Context

@tclune made some updates to ESMA_cmake to better support NAG Fortran. I think this is more needed in MAPL 3 development (#1538), but this update doesn't hurt MAPL 2. Thus, I pull it here and we'll merge up to develop/MAPL-v3

How Has This Been Tested?

I built GEOSgcm with ESMA_cmake v3.16.0 using GNU and it was zero-diff.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@mathomp4 mathomp4 added the 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. label Jun 3, 2022
@mathomp4 mathomp4 requested a review from a team as a code owner June 3, 2022 16:30
@mathomp4 mathomp4 self-assigned this Jun 3, 2022
@mathomp4
Copy link
Member Author

mathomp4 commented Jun 3, 2022

Huh. This broke with Intel. Okay. Time to test on discover!

@mathomp4
Copy link
Member Author

mathomp4 commented Jun 3, 2022

Interesting. It breaks with MAPL and Intel and only with GitHub Actions? Okay... getting confused...

@mathomp4
Copy link
Member Author

mathomp4 commented Jun 3, 2022

Not sure why it got triggered here in all places, but the GitHub Actions CI was out-of-date. It shouldn't have presented in the way it failed, but it seems to have fixed it so...good enough for me!

@mathomp4 mathomp4 merged commit 0b454fe into develop Jun 3, 2022
@mathomp4 mathomp4 deleted the feature/mathomp4/update-cmake-to-3160-mapl branch June 3, 2022 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants