Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Monotonic regridding #1528

Merged
merged 5 commits into from
May 26, 2022
Merged

Monotonic regridding #1528

merged 5 commits into from
May 26, 2022

Conversation

bena-nasa
Copy link
Collaborator

@bena-nasa bena-nasa commented May 26, 2022 •
edited
Loading

Adds monotonic regridding option. Made this available (as well as any regridding option we support) in History via a new keyword that will allow us to eventually deprecate "conservative". While I was at it I updated ExtData2G to allow for all regridding options to be specified, same with Regrid_Util.x

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@bena-nasa bena-nasa added 🎁 New Feature This is a new feature 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. labels May 26, 2022
@bena-nasa bena-nasa requested a review from tclune May 26, 2022 15:44
@bena-nasa bena-nasa requested a review from a team as a code owner May 26, 2022 15:44
tclune
tclune approved these changes May 26, 2022
View reviewed changes
Copy link
Collaborator

@tclune tclune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am wishing now that we could have a 2 parameter mechanism for regrid methods, as the "monotonic" modifier really could be applied to any of the methods, at least in principle.

@tclune tclune merged commit b806f17 into develop May 26, 2022
@tclune tclune deleted the feature/bmauer/constrain_minmax_regridding branch May 26, 2022 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsdunlapiv rsdunlapiv rsdunlapiv left review comments

@tclune tclune tclune approved these changes

Assignees
No one assigned
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 🎁 New Feature This is a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bena-nasa @rsdunlapiv @tclune