Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic restart skip #1516

Merged
merged 5 commits into from
May 18, 2022
Merged

Automatic restart skip #1516

merged 5 commits into from
May 18, 2022

Conversation

bena-nasa
Copy link
Collaborator

If a field makes it to ExtData, go through the hierarchy and make any component with that field in it's import MAPL_RestartSkip. Added new routine in MAPL_Generic to do this. This was requested by the chemistry folks so they don't have to remember to add restartskip and if something may or may not be provided by ExtData depending on the configuration of the system.

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@bena-nasa bena-nasa added 🎁 New Feature This is a new feature 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. labels May 17, 2022
@bena-nasa bena-nasa requested a review from a team as a code owner May 17, 2022 19:03
@bena-nasa bena-nasa requested a review from tclune May 17, 2022 19:03
atrayano
atrayano previously approved these changes May 17, 2022
Copy link
Collaborator

@tclune tclune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does any of this require an update as ESMF_Info on the V3 branch?

Minor changes requested.

@mathomp4
Copy link
Member

Does any of this require an update as ESMF_Info on the V3 branch?

@tclune Yes, it will. The ESMF_AttributeGet call will need to be an infoget.

Probably a good time to do a sweep of MAPL3 to see if any ESMF_Attribute calls have snuck in. (Maybe there is a way at ESMF_init time to pass a flag that doesn't allow any ESMF_Attribute calls? That way we can be strict.)

Co-authored-by: Tom Clune <thomas.l.clune@nasa.gov>
@bena-nasa
Copy link
Collaborator Author

Does any of this require an update as ESMF_Info on the V3 branch?

Minor changes requested.

Probably would

@bena-nasa bena-nasa requested a review from tclune May 18, 2022 15:23
@tclune tclune merged commit b153dbd into develop May 18, 2022
@tclune tclune deleted the feature/bmauer/auto_rstskip_extdata branch May 18, 2022 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 🎁 New Feature This is a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants