Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add loggers for generic stages #1510

Merged
merged 2 commits into from
May 17, 2022
Merged

Conversation

mathomp4
Copy link
Member

Description

As suggested by @LiamBindle, add loggers to tell when stages are executed during a run.

For now, we use the DEBUG logger as the INFO logger is currently the used by console in GEOSgcm so all prints are in the log if INFO. Eventually, we should update the GEOS logging.yaml file to make, say, a file for MAPL.GENERIC INFO log output.

Related Issue

Motivation and Context

Let's users track down when things run.

How Has This Been Tested?

Model runs. Can't affect the output.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@mathomp4 mathomp4 added the 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. label May 16, 2022
@mathomp4 mathomp4 requested a review from LiamBindle May 16, 2022 19:33
@mathomp4 mathomp4 self-assigned this May 16, 2022
@mathomp4 mathomp4 requested a review from a team as a code owner May 16, 2022 19:33
@mathomp4 mathomp4 changed the base branch from main to develop May 16, 2022 20:20
@tclune tclune merged commit 75ba56b into develop May 17, 2022
@tclune tclune deleted the feature/mathomp4/loggers-for-stages branch May 17, 2022 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants