Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ADAS CI #1509

Merged
merged 4 commits into from
May 16, 2022
Merged

Fix ADAS CI #1509

merged 4 commits into from
May 16, 2022

Conversation

mathomp4
Copy link
Member

Description

This PR fixes the GEOSadas build test in CI. This was exposed by #1506 and is due to changes in the develop branch of GEOSadas itself.

Related Issue

Motivation and Context

Keeps MAPL develop CI working with ADAS build testing.

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@mathomp4 mathomp4 added the 0 Diff Trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) label May 16, 2022
@mathomp4 mathomp4 requested a review from a team as a code owner May 16, 2022 18:58
@mathomp4 mathomp4 self-assigned this May 16, 2022
@mathomp4
Copy link
Member Author

Well nuts. I forgot how weird CircleCI is. Time to ponder...

@mathomp4
Copy link
Member Author

Graaaah! I will get this to work!

@mathomp4
Copy link
Member Author

Finally! I think this will work!

@mathomp4 mathomp4 merged commit 3ad1441 into develop May 16, 2022
@mathomp4 mathomp4 deleted the feature/mathomp4/fix-develop-adas-ci branch May 16, 2022 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mathomp4 mathomp4

Labels
0 Diff Trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mathomp4