Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #1378. Convert many _ASSERT(.false.) to _FAIL() #1493

Merged
merged 2 commits into from
May 2, 2022

Conversation

mathomp4
Copy link
Member

@mathomp4 mathomp4 commented May 2, 2022

Description

This is a cleanup PR. There were many instances of _ASSERT(.false., "msg") that should instead use _FAIL("msg").

Related Issue

Closes #1378

Motivation and Context

Makes the code cleaner.

How Has This Been Tested?

I'll need to test with a run of GEOSgcm. But if it compiles, it should work.

Tested and is zero-diff.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@mathomp4 mathomp4 added the 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. label May 2, 2022
@mathomp4 mathomp4 self-assigned this May 2, 2022
@mathomp4
Copy link
Member Author

mathomp4 commented May 2, 2022

Huh. Well, something didn't like this:

Error: detected recursion whilst expanding macro "_FAIL"

But I know we use _FAIL in MAPL so, I might need @tclune level macro help.

@mathomp4
Copy link
Member Author

mathomp4 commented May 2, 2022

Huh. Well, something didn't like this:

Error: detected recursion whilst expanding macro "_FAIL"

But I know we use _FAIL in MAPL so, I might need @tclune level macro help.

Wait. My fault. My sed was too aggressive!

@mathomp4
Copy link
Member Author

mathomp4 commented May 2, 2022

Welp. The model builds and runs and is zero-diff. I guess this is safe.

@mathomp4 mathomp4 marked this pull request as ready for review May 2, 2022 16:04
@mathomp4 mathomp4 requested a review from a team as a code owner May 2, 2022 16:04
@atrayano atrayano merged commit e09e158 into develop May 2, 2022
@mathomp4 mathomp4 deleted the feature/mathomp4/1378-fix-assert-false branch May 17, 2022 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants