Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExtData2G updates, bugs fixes and multiple filestream feature. #1475

Merged
merged 29 commits into from
Apr 15, 2022

Conversation

bena-nasa
Copy link
Collaborator

This is more development of ExtData 2.0
This fixes multiple bugs uncovered when testing with the real GEOSgcm system rather than my standalone tester.

This also implements the requested feature to use different rules for different time periods

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@bena-nasa bena-nasa added 🪲 Bugfix This fixes a bug! 🎁 New Feature This is a new feature 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. labels Apr 11, 2022
@bena-nasa bena-nasa requested review from a team as code owners April 11, 2022 20:33
@tclune tclune self-requested a review April 14, 2022 13:49
Copy link
Collaborator

@tclune tclune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better. Still a couple of small changes requested.

@tclune
Copy link
Collaborator

tclune commented Apr 15, 2022

Note - there are levels of debugging even lower than "DEBUG". The named levels are DEBUG, INFO, WARN, ... but they correspond to integers 10, 20, 30, ...

So you could make those "DEBUG" something like "9" and then they would only show up when you set the logger threshold to "9".

@bena-nasa bena-nasa requested a review from tclune April 15, 2022 20:00
@tclune tclune merged commit af4198c into develop Apr 15, 2022
@tclune tclune deleted the feature/bmauer/extdata2g_multiple_fstreams branch April 15, 2022 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 🪲 Bugfix This fixes a bug! 🎁 New Feature This is a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants