Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GNU Cubed Sphere Factory Bug #1461

Merged
merged 3 commits into from
Mar 28, 2022
Merged

Conversation

mathomp4
Copy link
Member

Description

This fixes a bug similar to that in #1433 but for the cubed-sphere factory.

Related Issue

#1433 ... ish

Motivation and Context

I found this trying to write out native CS History output with GNU. Fails without it.

How Has This Been Tested?

I tested with Intel and it was zero-diff with this fix. I also remembered to actually add a native collection, and they were zero-diff.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@mathomp4 mathomp4 added 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. bugfix labels Mar 28, 2022
@mathomp4 mathomp4 requested a review from a team as a code owner March 28, 2022 15:27
@mathomp4 mathomp4 self-assigned this Mar 28, 2022
@mathomp4 mathomp4 requested a review from a team as a code owner March 28, 2022 15:27
Copy link
Collaborator

@tclune tclune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor edit to the ChangeLog requested.

Co-authored-by: Tom Clune <thomas.l.clune@nasa.gov>
@mathomp4
Copy link
Member Author

Minor edit to the ChangeLog requested.

Done. And I don't mind the re-trigger of CI as the ADAS build failed in its usual 🤷🏼‍♂️ way. I really wish I could figure out what's going on...it's just like a 25% failure rate for no good reason.

@mathomp4 mathomp4 requested a review from tclune March 28, 2022 21:09
@tclune tclune merged commit 09840e7 into main Mar 28, 2022
@tclune tclune deleted the hotfix/mathomp4/fix-cubefactory-gnu branch March 28, 2022 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants