Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #1454. Now MAPL_Shmem memory is deallocated properly #1456

Merged
merged 3 commits into from
Mar 24, 2022
Merged

Fixes #1454. Now MAPL_Shmem memory is deallocated properly #1456

merged 3 commits into from
Mar 24, 2022

Conversation

atrayano
Copy link
Contributor

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • [x ] I have tested this change with a run of GEOSgcm (if non-trivial)
  • [x ] I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • [x ] I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@atrayano atrayano added 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. bugfix labels Mar 24, 2022
@atrayano atrayano requested a review from tclune March 24, 2022 16:25
@atrayano atrayano requested a review from a team as a code owner March 24, 2022 16:25
@atrayano atrayano self-assigned this Mar 24, 2022
tclune
tclune reviewed Mar 24, 2022
View reviewed changes
tclune
tclune reviewed Mar 24, 2022
View reviewed changes
@tclune tclune self-requested a review March 24, 2022 17:51
tclune
tclune previously approved these changes Mar 24, 2022
View reviewed changes
@mathomp4
Copy link
Member

Let me do a sanity check before I issue the release. For now, I'm going to hijack this PR to prepare for a release.

@atrayano atrayano requested a review from a team as a code owner March 24, 2022 18:38
@mathomp4
Copy link
Member

Let me do a sanity check before I issue the release. For now, I'm going to hijack this PR to prepare for a release. @tclune might need to re-approve.

@mathomp4 mathomp4 requested a review from tclune March 24, 2022 18:39
mathomp4
mathomp4 approved these changes Mar 24, 2022
View reviewed changes
Copy link
Member

@mathomp4 mathomp4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mathomp4 mathomp4 merged commit 3e2c0e1 into main Mar 24, 2022
@mathomp4 mathomp4 deleted the hotfix/atrayano/#1454_shmem_deallocate branch March 24, 2022 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathomp4 mathomp4 mathomp4 approved these changes

@tclune tclune Awaiting requested review from tclune

Assignees

@atrayano atrayano

Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@atrayano @mathomp4 @tclune