Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CI to use orb build job, Update components.yaml #1450

Merged
merged 6 commits into from
Mar 23, 2022
Merged

Update CI to use orb build job, Update components.yaml #1450

merged 6 commits into from
Mar 23, 2022

Conversation

mathomp4
Copy link
Member

@mathomp4 mathomp4 commented Mar 22, 2022 •
edited
Loading

Description

This PR updates MAPL CircleCI to use v1 of my circleci tools orb as well as the new job syntax. It's a bit nicer and more compact.

Also, update the components.yaml to match GEOSgcm v10.22.1.

Related Issue

Motivation and Context

Makes the CI even more compact and portable.

How Has This Been Tested?

No need to run GEOS as this does not affect the model, only CI.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@mathomp4 mathomp4 added 0 Diff Trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. labels Mar 22, 2022
@mathomp4 mathomp4 self-assigned this Mar 22, 2022
@mathomp4 mathomp4 marked this pull request as ready for review March 23, 2022 14:16
@mathomp4 mathomp4 requested a review from a team as a code owner March 23, 2022 14:16
tclune
tclune approved these changes Mar 23, 2022
View reviewed changes
Copy link
Collaborator

@tclune tclune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI changes ok

@mathomp4 mathomp4 merged commit b1513d8 into develop Mar 23, 2022
@mathomp4 mathomp4 deleted the feature/mathomp4/use-orb-job branch March 23, 2022 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tclune tclune tclune approved these changes

Assignees

@mathomp4 mathomp4

Labels
0 Diff Trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) 0 Diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mathomp4 @tclune