From 1bbfeb9920a09b56c4854478eadddfa65cbcc58b Mon Sep 17 00:00:00 2001 From: Matthew Thompson Date: Mon, 21 Mar 2022 10:18:56 -0400 Subject: [PATCH 1/3] Fix issue with calling ACG multiple times --- CHANGELOG.md | 2 ++ cmake/mapl_acg.cmake | 8 ++++---- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 3423e26c7526..c8d8a64c35a4 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -9,6 +9,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ### Fixed +- Fix issue where ACG was called when no file had changed + ### Added ### Changed diff --git a/cmake/mapl_acg.cmake b/cmake/mapl_acg.cmake index b55364233a70..d37f08eafc59 100644 --- a/cmake/mapl_acg.cmake +++ b/cmake/mapl_acg.cmake @@ -28,12 +28,12 @@ function (mapl_acg target specs_file) string (REPLACE "_GridComp" "" component_name ${target}) if (ARGS_UNPARSED_ARGUMENTS) - ecbuild_error ("maple_acg() - unparsed arguments: ${ARGS_UNPARSED_ARGUMENTS}") + ecbuild_error ("mapl_acg() - unparsed arguments: ${ARGS_UNPARSED_ARGUMENTS}") endif () set (generated) # empty unless set (options "") - + set (suffix_for_generated_include_files "___.h") # Handle oneValueArgs with no value (Python provides default) foreach (opt flag default IN ZIP_LISTS oneValueArgs flags defaults) @@ -44,7 +44,7 @@ function (mapl_acg target specs_file) list (APPEND options ${flag} ${ARGS_${opt}}) elseif (${opt} IN_LIST ARGS_KEYWORDS_MISSING_VALUES) string (REPLACE "{component}" component_name fname ${default}) - list (APPEND generated ${fname}) + list (APPEND generated "${component_name}_${fname}${suffix_for_generated_include_files}") list (APPEND options ${flag}) endif () @@ -60,7 +60,7 @@ function (mapl_acg target specs_file) add_custom_command ( OUTPUT ${generated} COMMAND ${generator} ${CMAKE_CURRENT_SOURCE_DIR}/${specs_file} ${options} - MAIN_DEPENDENCY ${CMAKE_CURRENT_SOURCE_DIR}/${specs_file} + MAIN_DEPENDENCY ${CMAKE_CURRENT_SOURCE_DIR}/${specs_file} DEPENDS ${generator} ${specs_file} WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR} COMMENT "Generating automatic code for ${specs_file}" From b93440465b1d39834b008e327ea51e9dd1684628 Mon Sep 17 00:00:00 2001 From: Matthew Thompson Date: Mon, 21 Mar 2022 14:25:04 -0400 Subject: [PATCH 2/3] Clean up some old CMake --- gridcomps/ExtData2G/CMakeLists.txt | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/gridcomps/ExtData2G/CMakeLists.txt b/gridcomps/ExtData2G/CMakeLists.txt index 6efdc8a2d362..e36dd802d311 100644 --- a/gridcomps/ExtData2G/CMakeLists.txt +++ b/gridcomps/ExtData2G/CMakeLists.txt @@ -26,7 +26,6 @@ set (srcs esma_add_library (${this} SRCS ${srcs} DEPENDENCIES MAPL.shared MAPL.base MAPL.generic MAPL.griddedio TYPE SHARED) target_link_libraries (${this} PUBLIC GFTL::gftl GFTL_SHARED::gftl-shared YAFYAML::yafyaml esmf NetCDF::NetCDF_Fortran PRIVATE MPI::MPI_Fortran) -target_include_directories (${this} PUBLIC ${INC_ESMF} ${INC_NETCDF} - $) +target_include_directories (${this} PUBLIC $) set_target_properties (${this} PROPERTIES Fortran_MODULE_DIRECTORY ${include_${this}}) From 5352963430dba4863d320848f9e69e3596cb2c92 Mon Sep 17 00:00:00 2001 From: Matthew Thompson Date: Mon, 21 Mar 2022 14:25:31 -0400 Subject: [PATCH 3/3] Update changelog --- CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index c8d8a64c35a4..aa37071a62ea 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -15,6 +15,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ### Changed +- Cleaned up a bit of old CMake + ### Removed ### Deprecated