Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

more flexible mangled names #1401

Merged
merged 4 commits into from
Mar 17, 2022
Merged

more flexible mangled names #1401

merged 4 commits into from
Mar 17, 2022

Conversation

weiyuan-jiang
Copy link
Contributor

@weiyuan-jiang weiyuan-jiang commented Mar 1, 2022 •
edited
Loading

replace "*" in any position of a string

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@weiyuan-jiang weiyuan-jiang added the 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. label Mar 1, 2022
@weiyuan-jiang weiyuan-jiang requested review from a team as code owners March 1, 2022 13:58
tclune
tclune previously approved these changes Mar 1, 2022
View reviewed changes
@weiyuan-jiang weiyuan-jiang added the 🚫 Contingent - DNA Do Not Approve (DNA). These changes are contingent on other PRs label Mar 1, 2022
@weiyuan-jiang weiyuan-jiang changed the title more flexible mingled names more flexible mangled names Mar 17, 2022
@tclune tclune removed the 🚫 Contingent - DNA Do Not Approve (DNA). These changes are contingent on other PRs label Mar 17, 2022
@tclune tclune self-requested a review March 17, 2022 20:43
@mathomp4 mathomp4 requested a review from tclune March 17, 2022 20:45
@mathomp4 mathomp4 merged commit 857ff5e into develop Mar 17, 2022
@mathomp4 mathomp4 deleted the feature/wjiang/mingled_name branch March 17, 2022 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tclune tclune Awaiting requested review from tclune

Assignees
No one assigned
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@weiyuan-jiang @tclune @mathomp4