Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring ExtData2G into develop via optional build argument to cmake #1400

Merged
merged 21 commits into from
Mar 9, 2022

Conversation

bena-nasa
Copy link
Collaborator

This add the next generation of ExtData as a build option to satisfy Arlindo's request to be shift development of GOCART2G to use the new ExtData via a build time option so that they can start preparing for it as I work on implementing new functionality desired which will only be in the new ExtData.
This adds "USE_EXTDATA2G" option to cmake so that if set to ON it will build MAPL with the new ExtData. Default is "OFF"

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@bena-nasa bena-nasa added 🎁 New Feature This is a new feature 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. labels Feb 28, 2022
@bena-nasa bena-nasa requested review from a team as code owners February 28, 2022 19:25
@bena-nasa bena-nasa changed the title add ExtData2G with a USE_EXTDATA2G argument to cmake for user request Bring ExtData2G into develop via optional build argument to cmake Feb 28, 2022
Copy link
Collaborator

@tclune tclune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only substantive concern is whether there should be a run-time switch.

tclune
tclune previously approved these changes Mar 1, 2022
Co-authored-by: Matthew Thompson <matthew.thompson@nasa.gov>
tclune
tclune previously approved these changes Mar 1, 2022
@bena-nasa
Copy link
Collaborator Author

I've added this

@tclune tclune self-requested a review March 2, 2022 14:32
tclune
tclune previously approved these changes Mar 2, 2022
tclune
tclune previously approved these changes Mar 2, 2022
@mathomp4
Copy link
Member

mathomp4 commented Mar 7, 2022

Interesting. We are now failing in the UFS build style. This build uses:

-DBUILD_WITH_FLAP=OFF -DBUILD_WITH_PFLOGGER=OFF -DBUILD_SHARED_MAPL=OFF

and this is somehow triggering on:

use yafyaml

@bena-nasa My guess is this line:

target_link_libraries (${this} PUBLIC GFTL::gftl GFTL_SHARED::gftl-shared esmf NetCDF::NetCDF_Fortran

needs an explicit YAFYAML::yafyaml (I suppose after the gftl bits so we keep GFE near GFE?).

It's probably currently getting yaFyaml through pFlogger via one of the other MAPL dependencies when we build with pFlogger. But without pFlogger, it needs an explicit dependence.

@mathomp4 mathomp4 requested a review from tclune March 9, 2022 14:54
@tclune tclune merged commit 85be3ea into develop Mar 9, 2022
@tclune tclune deleted the feature/bmauer/extdata_2g branch March 9, 2022 15:02
@mathomp4 mathomp4 mentioned this pull request Mar 9, 2022
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 🎁 New Feature This is a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants