-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring ExtData2G into develop via optional build argument to cmake #1400
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My only substantive concern is whether there should be a run-time switch.
Co-authored-by: Matthew Thompson <matthew.thompson@nasa.gov>
I've added this |
…into feature/bmauer/extdata_2g
…hile trying to debug something. Fixed gnu build bug for now
…into feature/bmauer/extdata_2g
Interesting. We are now failing in the UFS build style. This build uses:
and this is somehow triggering on: use yafyaml @bena-nasa My guess is this line: MAPL/gridcomps/ExtData2G/CMakeLists.txt Line 27 in a922047
needs an explicit YAFYAML::yafyaml (I suppose after the gftl bits so we keep GFE near GFE?).
It's probably currently getting yaFyaml through pFlogger via one of the other MAPL dependencies when we build with pFlogger. But without pFlogger, it needs an explicit dependence. |
This add the next generation of ExtData as a build option to satisfy Arlindo's request to be shift development of GOCART2G to use the new ExtData via a build time option so that they can start preparing for it as I work on implementing new functionality desired which will only be in the new ExtData.
This adds "USE_EXTDATA2G" option to cmake so that if set to ON it will build MAPL with the new ExtData. Default is "OFF"
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist: