Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose new MAPL field bundle subroutines via "use MAPL" #1398

Merged
merged 3 commits into from
Feb 25, 2022

Conversation

bena-nasa
Copy link
Collaborator

@bena-nasa bena-nasa commented Feb 25, 2022

Larry needs to use my MAPL_read_bundle subroutine (replacement for MAPL_CFIORead) as the current MAPL_CFIORead chokes on our current cubed sphere files (this is needed for R21C as they have some cubed-sphere precip correction files to read) and the simple solution is to use the routine I made to replace MAPL_CFIORead. When he tried this in a few GEOS gridcomps, I found out that apparently "use MAPL" does not expose this so I'm updating MAPL.F90 to expose this.

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@bena-nasa bena-nasa added the 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. label Feb 25, 2022
@bena-nasa bena-nasa requested a review from a team as a code owner February 25, 2022 20:45
@bena-nasa bena-nasa added the 🎁 New Feature This is a new feature label Feb 25, 2022
@bena-nasa bena-nasa requested a review from tclune February 25, 2022 20:45
@tclune tclune merged commit 627892f into develop Feb 25, 2022
@tclune tclune deleted the feature/bmauer/expose_fieldbundle_io branch February 25, 2022 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 🎁 New Feature This is a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants