Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reverts the changes from PR #1359 #1394

Merged
merged 1 commit into from
Feb 25, 2022
Merged

Reverts the changes from PR #1359 #1394

merged 1 commit into from
Feb 25, 2022

Conversation

mathomp4
Copy link
Member

@mathomp4 mathomp4 commented Feb 25, 2022 •
edited
Loading

Description

This PR reverts the changes in #1359

Related Issue

Motivation and Context

It was decided this code should go to MAPL v3 and not MAPL 2 develop.

How Has This Been Tested?

I will build and run a GEOSgcm run with it.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@mathomp4 mathomp4 added the 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. label Feb 25, 2022
@mathomp4 mathomp4 self-assigned this Feb 25, 2022
@tclune tclune marked this pull request as ready for review February 25, 2022 14:51
@tclune tclune requested review from a team as code owners February 25, 2022 14:51
@tclune tclune marked this pull request as draft February 25, 2022 14:51
tclune
tclune approved these changes Feb 25, 2022
View reviewed changes
Copy link
Collaborator

@tclune tclune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@mathomp4 mathomp4 marked this pull request as ready for review February 25, 2022 15:01
@mathomp4
Copy link
Member Author

I built and ran GEOSgcm with Intel Release and all worked!

@mathomp4 mathomp4 merged commit eb7bd13 into develop Feb 25, 2022
@mathomp4 mathomp4 deleted the revert/mathomp4/revert-PR1359 branch February 25, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tclune tclune tclune approved these changes

Assignees

@mathomp4 mathomp4

Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mathomp4 @tclune