Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added new gauge for memory profiling. #1362

Merged
merged 4 commits into from
Feb 17, 2022
Merged

Added new gauge for memory profiling. #1362

merged 4 commits into from
Feb 17, 2022

Conversation

tclune
Copy link
Collaborator

@tclune tclune commented Feb 15, 2022

Instrument MAPL Generic and Cap with these and added a report at the
end of the run.

Description

New memory profiling capability.

Related Issue

Motivation and Context

We want to know where memory is consumed in the model.

How Has This Been Tested?

Tested with C12 + Intel on discover.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@tclune
Added new gauge for memory profiling.
497e007 
Instrument MAPL Generic and Cap with these and added a report at the
end of the run.
@tclune tclune added 🎁 New Feature This is a new feature 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. labels Feb 15, 2022
@tclune tclune requested review from a team as code owners February 15, 2022 18:00
mathomp4
mathomp4 approved these changes Feb 17, 2022
View reviewed changes
Copy link
Member

@mathomp4 mathomp4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems good. I know @tclune ran the model and this better not change the results!

@tclune tclune merged commit c71ea01 into develop Feb 17, 2022
@tclune tclune deleted the feature/mem-profile branch February 17, 2022 21:33
@mathomp4 mathomp4 mentioned this pull request Feb 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathomp4 mathomp4 mathomp4 approved these changes

Assignees
No one assigned
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 🎁 New Feature This is a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tclune @mathomp4 @aoloso