Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more infomation if get_var fails #1339

Merged
merged 3 commits into from
Apr 19, 2022
Merged

Conversation

weiyuan-jiang
Copy link
Contributor

@weiyuan-jiang weiyuan-jiang commented Feb 6, 2022

provide more information if reading variables from netcdf file failed

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@weiyuan-jiang weiyuan-jiang requested a review from a team as a code owner February 6, 2022 19:48
@weiyuan-jiang weiyuan-jiang added 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 🚫 Contingent - DNA Do Not Approve (DNA). These changes are contingent on other PRs labels Feb 6, 2022
@weiyuan-jiang
Copy link
Contributor Author

Part of the effort to address issue #1285 .

@mathomp4
Copy link
Member

mathomp4 commented Feb 7, 2022

@weiyuan-jiang Is there a reason you are blocking this? More updates coming?

(And I guess, did you test this with a GEOS run?)

@weiyuan-jiang
Copy link
Contributor Author

@weiyuan-jiang Is there a reason you are blocking this? More updates coming?

(And I guess, did you test this with a GEOS run?)

Yes, I block this PR because @rmontuoro reported that there was still un-trapped error. I am wondering if that is reproducible on our GEOSgcm

@stale
Copy link

stale bot commented Apr 8, 2022

This issue has been automatically marked as stale because it has not had recent activity. If there are no updates within 7 days, it will be closed. You can add the "long term" tag to prevent the Stale bot from closing this issue.

@stale stale bot added the ❄️ Stale This issue has been marked stale label Apr 8, 2022
@mathomp4 mathomp4 added the ⌛ Long Term Long term issues label Apr 11, 2022
@stale stale bot removed the ❄️ Stale This issue has been marked stale label Apr 11, 2022
@mathomp4 mathomp4 added 0 Diff Trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) Skip Changelog and removed 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 🚫 Contingent - DNA Do Not Approve (DNA). These changes are contingent on other PRs labels Apr 19, 2022
@mathomp4 mathomp4 merged commit ad9f468 into develop Apr 19, 2022
@mathomp4 mathomp4 deleted the feature/wjiang/get_var_info branch April 19, 2022 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff Trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) ⌛ Long Term Long term issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants