Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1295. Clean up ESMC use #1304

Merged
merged 6 commits into from
Jan 26, 2022
Merged

Conversation

mathomp4
Copy link
Member

Description

This removes the #include "ESMC_ReturnCodes.h" that was in MAPL_Exceptions.h. It then turns out you can then replace all the ESMC_RC_ codes in MAPL_Config.F90 to ESMF_RC_ that I suppose are provided via use ESMF?

Related Issue

Closes #1295

Motivation and Context

Cleans up MAPL a bit.

How Has This Been Tested?

It built and ran GEOS just fine.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@mathomp4 mathomp4 added the 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. label Jan 13, 2022
@mathomp4 mathomp4 requested a review from a team as a code owner January 13, 2022 22:01
@mathomp4 mathomp4 self-assigned this Jan 13, 2022
@mathomp4 mathomp4 changed the base branch from main to develop January 13, 2022 22:01
@mathomp4
Copy link
Member Author

Huh. This looks like an annoying CircleCI issue. Re-running

@mathomp4
Copy link
Member Author

Yay! Passed!

@mathomp4 mathomp4 merged commit 0a2cf5f into develop Jan 26, 2022
@mathomp4 mathomp4 deleted the feature/mathomp4/#1295-clean-up-esmc branch January 26, 2022 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor ESMF Error code use
2 participants